Core Contracts

Summary

There is a double check for the contract paused state.

Vulnerability Details

In the updateUserBoost() function of the BoostController contract, there is a redundant check for the paused state using if (paused()) revert EmergencyPaused();. This check is unnecessary because the function is already decorated with the whenNotPaused modifier, which ensures that the function cannot be executed when the contract is paused.

Removing this redundant line will simplify the code and prevent any potential confusion about the contract's paused state handling.

Impact

Unnecessary gas spending.

Tools Used

Manual Review

Recommendations

Remove the redundant if (paused()) revert EmergencyPaused(); line from the updateUserBoost() function.