Submission Details
Severity:
Incorrect `Burn` event emission (scaled amount instead of amount in underlying asset unit) in DebtToken contract.
Summary
The burn function in DebtToken contract emits the following event:
emit Burn(from, amountScaled, index);
with:
/**
* @notice Emitted when debt tokens are burned
* @param from The address from which tokens are burned
* @param amount The amount burned (in underlying asset units)
* @param index The usage index at the time of burning
*/
event Burn(address indexed from, uint256 amount, uint256 index);
amount should be in underlying asset units, but the burn function actually passes the amount in debt token units:
uint256 amountScaled = amount.rayDiv(index);
if (amountScaled == 0) revert InvalidAmount();
_burn(from, amount.toUint128());
emit Burn(from, amountScaled, index);
amountScaled is the amount divided by the index to get the amount in debt token index. amount should be passed when emitting the event.
Impact
The impact of this issue is medium as it leads to event emission with incorrect data, leading to important front-end integration issues.
Tools Used
Manual review.
Recommendations
Make sure to pass the right value to for the amount key in the Burn event:
emit Burn(from, amount, index);
Updates
Lead Judging Commences
inallhonesty about 2 months ago
Submission Judgement Published Assigned finding tags:
DebtToken::burn emits Burn event with scaled amount instead of raw amount, contradicting documentation and causing incorrect off-chain data
inallhonesty about 2 months ago
Submission Judgement Published Assigned finding tags:
DebtToken::burn emits Burn event with scaled amount instead of raw amount, contradicting documentation and causing incorrect off-chain data
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.