Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: high
Invalid

`BaseChainlinkFunctionsOracle.sol#fulfillRequest`: `requestId` is not checked

wiasliaw

Vulnerability Details

The information passed into fulfillRequest should check to match the request ID obtained from _sendRequest.

/// @dev https://github.com/Cyfrin/2025-02-raac/blob/89ccb062e2b175374d40d824263a4c0b601bcb7f/contracts/core/oracles/BaseChainlinkFunctionsOracle.sol#L99-L113
​
function fulfillRequest(
bytes32 requestId,
bytes memory response,
bytes memory err
) internal override {
// ...
}

Impact

Malicious actors can use past request information to update the price, causing the reported price to reflect outdated values.

Tools Used

Maunal.

Recommendations

Check the request id:

if (requestId != s_lastRequestId) revert();
Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Out of scope
inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Out of scope

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!