Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

Missing Minimum Delay in TimelockController::executeEmergencyAction Function

josh4324

Summary

The executeEmergencyAction function allows privileged roles to execute urgent governance actions without going through the standard governance process. According to the documentation, there should be a minimum delay of 1 day before an emergency action can be executed after it has been scheduled. However, this delay was not implemented in the function, allowing emergency actions to be executed immediately.

Vulnerability Details

function executeEmergencyAction(
address[] calldata targets,
uint256[] calldata values,
bytes[] calldata calldatas,
bytes32 predecessor,
bytes32 salt
) external payable onlyRole(EMERGENCY_ROLE) nonReentrant {
bytes32 id = hashOperationBatch(targets, values, calldatas, predecessor, salt);
if (!_emergencyActions[id]) revert EmergencyActionNotScheduled(id);
delete _emergencyActions[id];
​
for (uint256 i = 0; i < targets.length; i++) {
(bool success, bytes memory returndata) = targets[i].call{value: values[i]}(calldatas[i]);
if (!success) {
if (returndata.length > 0) {
assembly {
let returndata_size := mload(returndata)
revert(add(32, returndata), returndata_size)
}
}
revert CallReverted(id, i);
}
}
​
emit EmergencyActionExecuted(id);
}
​

The function allows an emergency action to be executed immediately after scheduling, bypassing the intended 1-day delay. This contradicts the expected governance mechanism stated in the documentation.

Impact

Emergency actions can execute instantly, bypassing governance security measures.

Tools Used

Manual Review

Recommendations

Modify executeEmergencyAction to ensure a minimum delay of 1 day (86400 seconds) before execution.

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

TimelockController emergency actions bypass timelock by not enforcing EMERGENCY_DELAY, allowing immediate execution

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

TimelockController emergency actions bypass timelock by not enforcing EMERGENCY_DELAY, allowing immediate execution

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!