Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

Cannot update 2 feeTypes.

octeezy

Summary

The updateFeeType function in FeeCollector.sol is meant to update feeType percentages but this can't be done for Buy/Sell Swap Tax and NFT Royalty Fees feeTypes given that they are not meant to sum 100%.

Vulnerability Details

The updateFeeType function includes the following validation.

if (newFee.veRAACShare + newFee.burnShare + newFee.repairShare + newFee.treasuryShare != BASIS_POINTS) {
revert InvalidDistributionParams();
}

Which checks that the new fee configuration adds up to exactly 100%. Given their initial configuration the last 2 feeTypes are meant sum a 2% total for each feeType, meaning that these 2 feeTypes are not upgradeable using this function.

Impact

2 feeTypes are not upgradeable.

Tools Used

Manual review.

Recommendations

Extend the functionality to check for feeTypes 6 and 7.

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!