Submission Details
Severity:
Unchecked Array Length in Batch Operations Low Risk
Summary
The addNewBatch function in RAACNFT only checks if the batch size is non-zero but doesn't check for reasonable upper limits:
function addNewBatch(uint256 _batchSize) public override onlyOwner {
if (_batchSize == 0) revert RAACNFT__BatchSize();
currentBatchSize += _batchSize;
}
Impact
While this might not lead to direct security vulnerabilities, it could result in operational issues:
1. An excessively large batch size could make batch operations too gas-intensive to execute
2. The currentBatchSize could grow unreasonably large over time if not properly managed
3. No checks for arithmetic overflow in the addition operation
Tools Used
Manual review
Recommendations
Add validation checks to make sure it's within reasonable upper limits
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.