Submission Details
Severity:
Function `_mintRAACRewards` should be called before setting `setRAACMinter`
Summary
If the stability pool updates the raacMinter via setRAACMinter() without calling _mintRAACRewards, then it would lose out on raac rewards accumulated since the last time we last called the function.
Vulnerability Details
If the owner updates the raacMinter in StabilityPool without calling the _mintRAACRewards() on previous raacMinter, then we would lose raac rewards accumulated since the last time we called it i.e. setRaacMinter()
function setRAACMinter(address _raacMinter) external onlyOwner {
raacMinter = IRAACMinter(_raacMinter);
}
Impact
StabilityPool will lose RAAC Rewards
Tools Used
Manual
Recommendations
Consider adding a call to _mintRAACRewards() i.e.
function setRAACMinter(address _raacMinter) external onlyOwner {
_mintRAACRewards(); // add this
raacMinter = IRAACMinter(_raacMinter);
}
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.