Submission Details
Severity:
Emergency Withdrawal Bypasses Treasury Accounting System
Summary
FeeCollector's emergencyWithdraw function uses direct token transfers instead of Treasury's deposit function, breaking balance tracking and potentially trapping funds.
Vulnerability Details
The emergencyWithdraw function bypasses proper accounting:
if (token == address(raacToken)) {
balance = raacToken.balanceOf(address(this));
raacToken.safeTransfer(treasury, balance); // Direct transfer bypasses accounting
}
Impact
Funds directly transferred will be locked since the withdrawal relies on _balances[token] and not balanceOf()
Tools Used
Manual review
Recommendations
Use Treasury's deposit function instead of direct transfer:
if (token == address(raacToken)) {
balance = raacToken.balanceOf(address(this));
- raacToken.safeTransfer(treasury, balance);
+ raacToken.approve(treasury, balance);
+ ITreasury(treasury).deposit(address(raacToken), balance);
}
Updates
Lead Judging Commences
inallhonesty 3 months ago
Submission Judgement Published Assigned finding tags:
FeeCollector::_processDistributions and emergencyWithdraw directly transfer funds to Treasury where they get permanently stuck
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.