Submission Details
Severity:
Wrong Swap tax and NFT Royalty fees
In the _initializeFeeTypes() function, some fee types have incorrect percentage set. We can clearly see that BASIS_POINTS are set to 10000, which means that the procent representation is as follows: 1000 - 10%, 100 - 1%, 50 - 0.5%
uint256 public constant BASIS_POINTS = 10000;
Recommendation
Ensure that the calculations correctly align with BASIS_POINTS and adjust values accordingly.
[contracts/core/collectors/FeeCollector.sol]
379 // Buy/Sell Swap Tax (2% total)
380 feeTypes[6] = FeeType({
- 381 veRAACShare: 500, // 0.5%
+ 381 veRAACShare: 50, // 0.5%
- 382 burnShaer: 500, // 0.5%
+ 382 burnShaer: 50, // 0.5%
- 383 repairShare: 1000, // 1.0%
+ 383 repairShare: 100, // 1.0%
384 treasuryShare: 0
385 });
386
387 // NFT Royalty Fees (2% total)
388 feeTypes[7] = FeeType({
- 389 veRAACShare: 500, // 0.5%
+ 389 veRAACShare: 50, // 0.5%
390 burnShare: 0,
- 391 repairShare: 1000, // 1.0%
+ 391 repairShare: 100, // 1.0%
- 392 treasuryShare: 500 // 0.5%
+ 392 treasuryShare: 50 // 0.5%
393 });
Updates
Lead Judging Commences
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.