Core Contracts

Summary

The RAACMinter contract's setFeeCollector function incorrectly prohibits setting the fee collector to the zero address, preventing fee collection from being disabled as intended.

Vulnerability Details

In the RAACMinter contract, the setFeeCollector function includes the following check:

This check prevents an authorized updater from passing address(0) to disable fee collection. However, the corresponding RAACToken::setFeeCollector implementation in the RAAC token contract explicitly allows setting the fee collector to the zero address to disable fee collection:

Proof-of-Concept (POC)

1. Initial Call:
   An authorized user with the UPDATER_ROLE calls the function:

   setFeeCollector(address(0));

2. Execution:
   The function evaluates the condition:

   if (_feeCollector == address(0)) revert FeeCollectorCannotBeZeroAddress();

3. Result:
   The transaction reverts with FeeCollectorCannotBeZeroAddress(), blocking the attempt to disable fee collection.

4. Outcome:
   As a result, fee collection cannot be disabled, which contradicts the intended functionality provided by the RAAC token contract.

Impact

Administrators cannot disable fee collection when necessary, potentially causing unintended fee charges.

Tools Used

Manual Review

Recommendations

Remove the zero-address check in the setFeeCollector function of the RAACMinter contract to allow disabling fee collection, and update the access control modifier to onlyOwner to ensure consistency with the RAAC token contract.