Core Contracts

Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Submission Details
Severity: medium
Valid

RAACTokens sent to the `address(this)` by the `stabilityPool` by calling the `depositRAACFromPool()` will be locked.

Summary

The stabilityPool calls the `depositRAACFromPool` function and transfers some amount of RAACTokens to the contract, after the RAACTokens are sent, the tokens are meant to be distributed accross different managers based on their different allocations, but the function was not fully implemented.
In the `StabilityPool::depositRAACFromPool()` function, some amount of RAACTokens are sent by the stabilityPool to the `address(this)`, with no other functionality to allocate the tokens approptiately accross to the different managers. without the complete implementation, when the stabilityPool sends raacTokens to the contract using the `depositRAACFromPool` function the RAACTokens will remain locked in the contract.

function depositRAACFromPool(uint256 amount) external onlyLiquidityPool validAmount(amount) {
uint256 preBalance = raacToken.balanceOf(address(this));
raacToken.safeTransferFrom(msg.sender, address(this), amount);
uint256 postBalance = raacToken.balanceOf(address(this));
if (postBalance != preBalance + amount) revert InvalidTransfer();
// TODO: Logic for distributing to managers based on allocation
emit RAACDepositedFromPool(msg.sender, amount);
}

Impact

The Managers will not get any Tokens from the pool, even after some amount of tokens are already allocated to them.

Tools Used

manual analysis

Recommendations

The `depositRAACFromPool` function should be completed and correctly implemented.
Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

StabilityPool::calculateRaacRewards uses contract balance for reward calculation, incorrectly including tokens meant for manager allocation - Manager allocation not implemented

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

StabilityPool::calculateRaacRewards uses contract balance for reward calculation, incorrectly including tokens meant for manager allocation - Manager allocation not implemented

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.