Submission Details
Severity:
Unimplemented RAAC Distribution Logic in `depositRAACFromPool`
Summary
The depositRAACFromPool function lacks logic to distribute RAAC tokens to managers, causing rewards to remain stuck in the contract.
Vulnerability Details
The TODOcomment shows that the dev intends to add distribution logic for managers based on allocation. RAAC tokens deposited by the Liquidity Pool are not allocated to managers, violating incentive structures.
/**
* @notice Deposits RAAC tokens from the liquidity pool.
* @param amount Amount of RAAC tokens to deposit.
*/
function depositRAACFromPool(uint256 amount) external onlyLiquidityPool validAmount(amount) {
uint256 preBalance = raacToken.balanceOf(address(this));
raacToken.safeTransferFrom(msg.sender, address(this), amount);
uint256 postBalance = raacToken.balanceOf(address(this));
if (postBalance != preBalance + amount) revert InvalidTransfer();
// @audit dev forgot to implement the logic for distributing to managers based on allocation
// TODO: Logic for distributing to managers based on allocation
emit RAACDepositedFromPool(msg.sender, amount);
}
Impact
Managers do not receive rewards, leading to reduced participation.
RAAC remains unused in the contract, disrupting tokenomics.
Tools Used
manual code review
Recommendations
Allocate RAAC proportionally to managers based on their allocations
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
StabilityPool::calculateRaacRewards uses contract balance for reward calculation, incorrectly including tokens meant for manager allocation - Manager allocation not implemented
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
StabilityPool::calculateRaacRewards uses contract balance for reward calculation, incorrectly including tokens meant for manager allocation - Manager allocation not implemented
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.