Submission Details
Severity:
The mint function returns incorrect values in the correct order
Summary
The mint function returns incorrect values in the correct order
Vulnerability Details
* @return A tuple containing:
* - bool: True if this is the first mint for the recipient, false otherwise
* - uint256: The amount of scaled tokens minted
* - uint256: The new total supply after minting
* - uint256: The amount of underlying tokens minted
❌ return (isFirstMint, amountToMint, totalSupply(), amountScaled);
(bool isFirstMint, uint256 amountScaled, uint256 newTotalSupply, uint256 amountUnderlying) = IRToken(reserve.reserveRTokenAddress).mint(
In the RToken.sol contract, the return value order of the mint function is wrong. The problem occurs in the position of the second and fourth parameters.
Impact
The values of amountScaled and amountToMint are incorrect.
Tools Used
Manual review
Recommendations
The second parameter is amountScaled, and the fourth parameter is amountToMint.
✅ return (isFirstMint, amountScaled, totalSupply(), amountToMint);
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
RToken::mint doesn't return data in the right order, making the protocol emit wrong events
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
RToken::mint doesn't return data in the right order, making the protocol emit wrong events
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.