Core Contracts

Vulnerability Details

RAACMinter::BLOCKS_PER_DAY should not be a constant since the average block time is different on some EVM chains. Ethereum has an average of 12 seconds between two consecutive blocks, but Polygon for example has ~2 seconds of block time.
The number of blocks per day can then be different depending on the chain the protocol is deployed. And so everything related to it including the emissionRate, which will have unexpected values. Sidechains like Polygon should be compatible with RAAC since the Curve (crvUSD) is (see curve docs).

Recommendations

In RAACMinter.sol, Makes BLOCKS_PER_DAY an immutable and populate it value in the constructor with the correspoding block per day of the chain the contract is being deployed. Make the corresponding change in the contract for all the variable that use BLOCKS_PER_DAY.