The setBoostParameters
function allows setting a maxBoost value up to 5x, while the documentation states that the limit should be 2.5x. This inconsistency can lead to unintended behavior, potential system exploitation, and confusion for users and auditors.
In the code we have defined MAX_BOOST = 25000
and MIN_BOOST = 10000
however these values are not used in the validation for setBoostParameters.
If boosts were designed around 2.5x, increasing the cap to 5x could disrupt the balance of the system.
Manual code review
Use the defined Values instead of hardcoding the limit to be consistent.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.