Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

`GaugeController` does not `setWeeklyEmission/setEmission/setInitialWeight` directly.

kodyvim

setWeeklyEmission, setEmission and setInitialWeight have onlyController modifier but are not set directly by the gaugeController.

function setEmission(uint256 emission) external onlyController {
if (emission > periodState.emission) revert RewardCapExceeded();
periodState.emission = emission;
emit EmissionUpdated(emission);
}

While the owner can assign the controller role to himself. This create the possibility of these values being out of sync with the values held by the guageController which would lead to an incorrect state within the contracts.

Impact

Reward emissions can reach an incorrect state which can lead to total halt

Recommendation

These functions should be set and called directly from the GuageController to keep both contracts in sync.

Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

`setWeeklyEmission`, `setBoostParameters`, `setEmission` and `setInitialWeight` cannot be called due to controller access control - not implemented in controller

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

`setWeeklyEmission`, `setBoostParameters`, `setEmission` and `setInitialWeight` cannot be called due to controller access control - not implemented in controller

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.