Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing Zero-Balance Check in redeemAll() Function Leading to Gas Inefficiency

imran

Summary

The redeemAll() function in the smart contract lacks a validation check to ensure that the amount being redeemed is greater than zero before executing the _burn() and USDC.safeTransfer() operations. This oversight could result in unnecessary gas consumption and potential misuse of the function.

Vulnerability Details

The redeemAll() function allows users to redeem their tokens by burning them and transferring an equivalent amount of USDC to their address. However, the function does not verify whether the amount (i.e., the user's token balance) is greater than zero before proceeding with the following operations:

  1. Updating the totalZENORedeemed state variable.

  2. Burning the user's tokens via _burn().

  3. Transferring USDC to the user via USDC.safeTransfer().

If a user with a balance of zero calls this function:

  • The totalZENORedeemed state variable will remain unchanged.

  • The _burn() function will attempt to burn zero tokens, which has no effect but still consumes gas.

  • The USDC.safeTransfer() function will attempt to transfer zero tokens, which also consumes gas unnecessarily.

function redeemAll() external nonReentrant {
if (!isRedeemable()) {
revert BondNotRedeemable();
}
​
uint256 amount = balanceOf(msg.sender);
totalZENORedeemed += amount;
_burn(msg.sender, amount);
USDC.safeTransfer(msg.sender, amount);
}
​

The absence of a check to ensure that amount > 0 before proceeding with the redemption logic.

Impact

  • Users calling the function with a zero balance will waste gas on operations that have no meaningful effect.

Tools Used

  • Manual Code Review

Recommendations

A simple validation check should be added to ensure that the amount is greater than zero before proceeding with the redemption logic.

function redeemAll() external nonReentrant {
if (!isRedeemable()) {
revert BondNotRedeemable();
}
uint256 amount = balanceOf(msg.sender);
if (amount == 0) {
revert ZeroBalance(); // Add a custom error for clarity
}
totalZENORedeemed += amount;
_burn(msg.sender, amount);
USDC.safeTransfer(msg.sender, amount);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.