Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

collectFee should not have whenNotPaused

0xtheblackpanther

Description

The whenNotPaused modifier on collectFee() function in FeeCollector can lead to loss of fees during protocol emergency pauses.

function collectFee(uint256 amount, uint8 feeType) external override nonReentrant whenNotPaused returns (bool)

Protocol operations (swaps, lending, etc.) that occurred right before the pause would be unable to register their fees, leading to missing fee accounting and lost protocol revenue, along with this it leads to permanent inconsistency between actual fees generated and fees recorded

Recommendation

Remove whenNotPaused modifier from collectFee():

function collectFee(uint256 amount, uint8 feeType) external override nonReentrant returns (bool)
Updates

Lead Judging Commences

inallhonesty Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.