Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: high
Invalid

In `LendingPool` changing the `protocolFeeRate` does not increase the fee charged

ke1caM

Summary

Changing protocolFeeRate should increase the fee charged inside LendingPool but it does not do anything.

Vulnerability Details

Currently protocolFeeRate is set to zero, however if the protocol wishes to increase the fee rate to earn fees in the LendingPool, chaning the fee will not change anything.

function setProtocolFeeRate(uint256 newProtocolFeeRate) external onlyOwner {
rateData.protocolFeeRate = newProtocolFeeRate;
}

The reason for that is the fact that protocolFeeRate is not involved in any calculations in the protocol, so changing the value will not increase the earned fees.

Impact

Increasing protocolFeeRate does not have any effect on fees earned. This breaks protocol functionality as positive protocolFeeRate should earn fees for the protocol but it does not.

Tools Used

Manual Review, Hardhat

Recommendations

Implement protocolFeeRate in LendingPool to earn fees when protocolFeeRate is increased.

Updates

Lead Judging Commences

inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.