Description & Impact
The current implementation allows anyone to call recordVote() for any address, thus stealing anyone's voting power:
function recordVote(
address voter,
uint256 proposalId
) external {
if (_hasVotedOnProposal[voter][proposalId]) revert AlreadyVoted();
_hasVotedOnProposal[voter][proposalId] = true;
uint256 power = getVotingPower(voter);
emit VoteCast(voter, proposalId, power);
}
Mitigation
function recordVote(
address voter,
uint256 proposalId
) external {
+ // Ensure only the voter can record their own vote
+ require(msg.sender == voter, "Only voter can record their vote");
if (_hasVotedOnProposal[voter][proposalId]) revert AlreadyVoted();
_hasVotedOnProposal[voter][proposalId] = true;
uint256 power = getVotingPower(voter);
emit VoteCast(voter, proposalId, power);
}