Submission Details
Severity:
Incorrect Calculation of `ReserveLibrary::getNormalizedDebt` function in a case of `timeDelta` equals to zero
Vulnerability Details
The ReserveLibrary::getNormalizedDebt function is intended to return updated reserve.usageIndex variable. however in a case of timeDelta equals to zero, it returns reserve.totalUsage variable.
if (timeDelta < 1) {
return reserve.totalUsage;
}
Impact
Incorrect calculation
Tools Used
Manual review
Recommendations
Simply change the function like bellow :
function getNormalizedDebt(ReserveData storage reserve, ReserveRateData storage rateData) internal view returns (uint256) {
uint256 timeDelta = block.timestamp - uint256(reserve.lastUpdateTimestamp);
if (timeDelta < 1) {
- return reserve.totalUsage;
+ return reserve.usageIndex;
}
return calculateCompoundedInterest(rateData.currentUsageRate, timeDelta).rayMul(reserve.usageIndex);
}
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
getNormalizedDebt returns totalUsage (amount) instead of usageIndex (rate) when timeDelta < 1, breaking interest calculations across the protocol
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
getNormalizedDebt returns totalUsage (amount) instead of usageIndex (rate) when timeDelta < 1, breaking interest calculations across the protocol
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.