Core Contracts

Summary

Some fee shares (Buy/Sell Swap Tax and NFT Royalty Fees) are wrongly initialized inside the FeeCollector which makes the share recipients get imprecise fees. There is two major issues, one of them is deviating from the comments inside the code and the second one is violation of summation rule.

Vulnerability Details

According to the documents and natspec comments, we infer that there is a discrepancy when initializing the weights for different fee types. Especially if we take into account the natspec docs, the sum of the four fee share types should be equal to 10000 which is 100% in the basis point (even for insurance fees is a total of 3% from NFT loans). However, for the last two fee types (Buy/Sell Swap Tax (2% total) and NFT Royalty Fees (2% total)) there is no restriction and the sum of the fee shares is equal to 2000 or 20%.

Also if we consider the natspec comments here, we can see that the protocol intends to allocate the mentioned percentages with a basis point of 10000:

https://github.com/Cyfrin/2025-02-raac/blob/main/contracts/core/collectors/FeeCollector.sol#L379-L393

However, there is a discrepancy between the implemented code and the comment here as the 0.5% is not equal to 500 but 50 and 1% must be 100 instead of 1000.
So, here for the last two fee types, there are two main issues with the fee share distribution weights:

1. The sum of fee shares is not equal to the basis point (even is not equal to the 2% total mentioned in the natspec comment).

2. The comments deviate from the implemented code and show a 10x discrepancy.

Impact

Imprecise fee share distribution for the four shareholders due to the wrong initialized weights for the last two fee types (Buy/Sell Swap Tax and NFT Royalty Fees)

Tools Used

Manual

Recommendations

Consider modifying the weights for the last two fee types (Buy/Sell Swap Tax and NFT Royalty Fees) to ensure the correct percentages and also the summation rule (which should be equal to the basis point). Also, consider correcting the natspec comments.