Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: medium
Valid

[H] Incorrect Withdrawal in `_withdrawFromVault` Function in `LendingPool`

Singularity

Summary

The _withdrawFromVault function in the LendingPool contract processes the withdrawal to the LendingPool contract instead of the RToken contract where the deposits are made.

Vulnerability Details

The current withdrawal in the _withdrawFromVault function is:

curveVault.withdraw(amount, address(this), msg.sender, 0, new address[](0));

This line processes the withdrawal to the LendingPool contract, which does not hold the assets. The withdrawal should be processed to the RToken contract where the deposits are made.

Impact

This issue prevents the LendingPool contract from correctly withdrawing liquidity from the Curve vault, potentially leading to liquidity management issues within the protocol.

link to the issue: https://github.com/Cyfrin/2025-02-raac/blob/89ccb062e2b175374d40d824263a4c0b601bcb7f/contracts/core/pools/LendingPool/LendingPool.sol#L810

Tools Used

Manual code review.

Recommendations

Update the withdrawal to correctly process the withdrawal to the RToken contract. The corrected withdrawal should be:

curveVault.withdraw(amount, reserve.reserveRTokenAddress, msg.sender, 0, new address[](0));

This ensures that the withdrawn amount is correctly processed to the RToken contract where the deposits are made.

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

LendingPool::_depositIntoVault and _withdrawFromVault don't transfer tokens between RToken and LendingPool, breaking Curve vault interactions

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

LendingPool::_depositIntoVault and _withdrawFromVault don't transfer tokens between RToken and LendingPool, breaking Curve vault interactions

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!