Core Contracts

Relevant GitHub Links

https://github.com/Cyfrin/2025-02-raac/blob/89ccb062e2b175374d40d824263a4c0b601bcb7f/contracts/core/governance/gauges/BaseGauge.sol#L469

Summary

BaseGauge.sol creates double-length gaps between voting periods due to incorrect calculation of the next period start time, reducing protocol efficiency and voting participation. It creates potentially long periods when this functionality is blocked.

This calculation is used in multiple places in code.

Vulnerability Details

In BaseGauge.sol, several functions calculate the next period start using:

This creates an unnecessary extra period gap. Adding 2 instead of 1 doubles the waiting time between periods.

Example:

• Current time: 100

• Period duration: 30

• Current calculation (+ 2): ((100/30) + 2) * 30 = 150 (50 blocks gap)

• Correct calculation (+ 1): ((100/30) + 1) * 30 = 120 (20 blocks gap)

The + 2 creates an unnecessary extra period of delay between votes.

Impact

• Creates unnecessary gaps between voting periods

• Reduces voting participation opportunities

• Decreases protocol efficiency

• Affects both RAACGauge (7 day periods) and RWAGauge (30 day periods)

Tools Used

Manual review

Recommendations

Change the period start calculation to use + 1 instead of + 2:

This maintains necessary period separation while eliminating unnecessary gaps.