Submission Details
Severity:
Missing Token ID Validation in NFT Mint Function
Summary
The mint function in RAACNFT contract lacks validation for token ID existence and range, potentially allowing minting of duplicate NFTs or NFTs with IDs outside the allowed range.
Vulnerability Details
function mint(uint256 _tokenId, uint256 _amount) public override {
uint256 price = raac_hp.tokenToHousePrice(_tokenId);
if(price == 0) { revert RAACNFT__HousePrice(); }
if(price > _amount) { revert RAACNFT__InsufficientFundsMint(); }
// No check if tokenId > currentBatchSize
// No check if tokenId already exists
token.safeTransferFrom(msg.sender, address(this), _amount);
_safeMint(msg.sender, _tokenId);
...
}
The function fails to validate:
If the tokenId is within the current batch range (currentBatchSize)
If an NFT with this tokenId already exists
If the tokenId is valid (e.g., non-zero)
Impact
Potential minting of duplicate tokens.
Tools Used
Manual review
Recommendations
Add proper validation checks.
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.