Core Contracts

Summary

The protocol hardcodes BLOCKS_PER_DAY = 7200, assuming Ethereum's 12-second blocks. This creates two critical miscalculations on other EVM chains

Vulnerability Details

the main issue is in RAACMinter.sol's use of BLOCKS_PER_DAY as a constant, leading to incorrect emission rates on chains with different block times. Similarly, any per-block calculations that don't adjust for block time would cause discrepancies in APRs or emission schedules

https://github.com/Cyfrin/2025-02-raac/blob/89ccb062e2b175374d40d824263a4c0b601bcb7f/contracts/core/minters/RAACMinter/RAACMinter.sol#L28

for example

Chain Actual Blocks/Day RAAC Code Assumption Error Factor

Ethereum 7,200 7,200 1x

BNB Chain 28,800 7,200 4x under

Fantom 86,400 7,200 12x under

Daily RAAC emissions become 12x higher than intended on Fantom (86k blocks/day vs. 7.2k assumed)

Impact

The impact would be that emissions are too high or too low depending on the chain's block time

Tools Used

Recommendations

Chain-Aware Block Parameterization