Submission Details
Severity:
Incorrect Error Message Used in Operation Cancellation (Wrong Error Enum)
Link to Affected Code:
// contracts/core/governance/proposals/TimelockController.sol
function cancel(bytes32 id) external override onlyRole(CANCELLER_ROLE) {
if (_operations[id].timestamp == 0) {
revert OperationNotFound(id);
}
if (_operations[id].executed) {
revert OperationAlreadyScheduled(id); // Wrong error used
}
Description:
The cancel() function uses the wrong error message when checking if an operation has already been executed. It reverts with OperationAlreadyScheduled when it should use OperationAlreadyExecuted. This inconsistency between the error message and the actual condition being checked could cause confusion during error handling and debugging.
Impact:
Incorrect error reporting
Confusion during error handling
Recommended Mitigation:
function cancel(bytes32 id) external override onlyRole(CANCELLER_ROLE) {
if (_operations[id].timestamp == 0) {
revert OperationNotFound(id);
}
if (_operations[id].executed) {
revert OperationAlreadyExecuted(id); // Correct error
}
delete _operations[id];
emit OperationCancelled(id);
}
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.