Core Contracts

Summary

In the cancel function in TimelockController contract, if an operation is already executed, the function reverts with the error OperationAlreadyScheduled instead of OperationAlreadyExecuted. This is a semantic error in the error messaging.

Impact

Although this error does not compromise security, it misleads users and developers by providing an inaccurate error message. Such confusion can complicate debugging and audit processes, making it harder to understand the actual state of operations.

Recommendations

Correct the error in the cancel function to revert with the appropriate error message, i.e. OperationAlreadyExecuted, when an operation is already executed.