Core Contracts

Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Submission Details
Severity: low
Invalid

The constant EMERGENCY_ADMIN is declared but never used

Location: BoostController.sol

Description:

The constant EMERGENCY_ADMIN is declared within the BoostController contract but is never actually referenced or used within the code. This indicates unnecessary code that could potentially confuse future developers and increases the contract's size, albeit negligibly.

bytes32 public constant EMERGENCY_ADMIN = keccak256("EMERGENCY_ADMIN");

Impact:

  • Code Clarity: The presence of an unused constant can lead to confusion for developers reading or maintaining the code. They might assume there's some intended functionality related to an emergency admin role that doesn't exist.

  • Contract Size: While the impact is minimal, the constant does contribute slightly to the contract's size, which can affect deployment costs.

Recommendation:

Remove the unused constant from the code. This will improve code clarity and reduce unnecessary code.

// Remove this line:
// bytes32 public constant EMERGENCY_ADMIN = keccak256("EMERGENCY_ADMIN");

Rationale:

Removing the unused constant eliminates a potential source of confusion and makes the code more concise, without impacting any existing functionality.

Updates

Lead Judging Commences

inallhonesty Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.