Core Contracts

Summary

In the FeeCollector.sol, BaseGauge.sol and Governance.sol contracts there are multiple internal unused functions, which can lead to unnecessary code complexity and potential maintenance issues.

Vulnerability Details

The vulnerability arises from the presence of multiple internal functions that are not used anywhere in the contract. Unused functions can increase the complexity of the codebase, making it harder to maintain and understand.

The functions are:

• FeeCollector::_updateLastClaimTime

• BaseGauge::_updateWeights

• Governance::_isProposalSuccessful

Impact

The impact of this vulnerability is that it increases the complexity of the codebase and makes it harder to maintain. Unused functions can lead to confusion among developers and increase the risk of introducing errors or security vulnerabilities in the future. While the immediate impact may be minimal, the long-term effects on code quality and maintainability can be significant.

Tools Used

Manual Review

Recommendations

To mitigate this vulnerability, remove the unused functions from the given contracts. This will simplify the codebase and reduce the risk of potential issues in the future.