Incorrect Boost Multiplier Calculation in `BoostController::getBoostMultiplier`
Summary
The BoostController::getBoostMultiplier function incorrectly calculates the boost multiplier for a user in a pool. The variable userBoost.amount is used in both the numerator and denominator in a way that cancels itself out, causing the function to always return a constant value. This renders the function ineffective for determining user-specific boosts.
Vulnerability Details
The calculation in the function is as follows:
Since baseAmount is derived from userBoost.amount, it returns `MAX_BOOST`.
Impact
The function does not accurately compute a user’s boost multiplier.
The boost mechanism may not work as intended, potentially undermining the protocol’s incentive structure.
Tools Used
Manula review
Recommendations
Correct the formula to ensure userBoost.amount properly influences the result
Lead Judging Commences
BoostController::getBoostMultiplier always returns MAX_BOOST for any non-zero boost due to mathematical calculation error, defeating the incentive mechanism
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.