Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: medium
Valid

BaseGauge contract shows incorrect periodFinish()

elser17

Summary

BaseGauge contract shows incorrect periodFinish()

Vulnerability Details

BaseGauge.periodFinish() expects to return the timestamp in which the period ends, but fails to do it properly as end timestamp is calculated as lastUpdateTime + getPeriodDuration(), being `lastUpdateTime` the timestamp at which rewards were last updated.

As `lastUpdateTime` is updated overtime, so will be periodFinish() meaning that the end timestamp of the period is never reached as it grows over time.

Impact

periodFinish() will never show the correct timestamp. As a result, lastTimeRewardApplicable() does not return the real last time that applies for rewards and `getRewardPerToken()` (which makes use of lastTimeRewardApplicable()) will miscalculate rewardPerTokenStored, leading to a much higher reward than expected.

Tools Used

Manual review

Recommendations

Correct the BaseGauge.periodFinish() function to return the true period end timestamp:

function periodFinish() public view returns (uint256) {
- return lastUpdateTime + getPeriodDuration();
+ return periodState.votingPeriod.startTime + getPeriodDuration();
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 3 months ago
Submission Judgement Published
Validated
Assigned finding tags:

BaseGauge period end time miscalculation creates circular dependency between periodFinish() and lastUpdateTime, preventing periods from naturally ending and disrupting reward distribution

inallhonesty Lead Judge 3 months ago
Submission Judgement Published
Validated
Assigned finding tags:

BaseGauge period end time miscalculation creates circular dependency between periodFinish() and lastUpdateTime, preventing periods from naturally ending and disrupting reward distribution

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.