Submission Details
Severity:
Imprecise Voting Window End Condition
Summary
The castVote function's end-time validation uses a > operator instead of >=, allowing votes to be cast exactly at the proposal's end time.
Vulnerability Details
Current implementation:
if (block.timestamp > proposal.endTime) {
revert VotingEnded(proposalId, proposal.endTime, block.timestamp);
}
This allows voting when block.timestamp equals proposal.endTime, potentially violating intended voting window constraints.
Impact
Possibility of votes being cast at the exact deadline
Potential inconsistency with expected governance timing rules
Tools Used
Manual code review
Recommendations
Update the time check to use
>=:
if (block.timestamp >= proposal.endTime) {
revert VotingEnded(proposalId, proposal.endTime, block.timestamp);
}
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
Governance::state and Governance::castVote use inconsistent time boundary checks, allowing votes at exactly proposal.endTime when state shows inactive
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.