Submission Details
Severity:
RAACMinter.mintRewards() emits incorrect event value when called
Summary
RAACMinter.mintRewards() emits incorrect event value when called
Vulnerability Details
RAACMinter.mintRewards() mint raacTokens if input amount is higher than excessTokens, the function emits RAACMinted event with the input amount value as parameter, however this is not the number of minted tokens.
Impact
Event is emitted with wrong value, the tokens that really were minted are not correctly represented.
Tools Used
Manual review
Recommendations
Use the correct parameter value for the event:
function mintRewards(address to, uint256 amount) external nonReentrant whenNotPaused {
if (msg.sender != address(stabilityPool)) revert OnlyStabilityPool();
uint256 toMint = excessTokens >= amount ? 0 : amount - excessTokens;
excessTokens = excessTokens >= amount ? excessTokens - amount : 0;
if (toMint > 0) {
raacToken.mint(address(this), toMint);
}
raacToken.safeTransfer(to, amount);
- emit RAACMinted(amount);
+ emit RAACMinted(toMint);
}
Updates
Lead Judging Commences
inallhonesty 3 months ago
Submission Judgement Published Assigned finding tags:
RAACMinter.mintRewards() emits incorrect event value when called
suggestion is something that is done by ERC20.mint() function
Appeal created
inallhonesty 3 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
RAACMinter.mintRewards() emits incorrect event value when called
suggestion is something that is done by ERC20.mint() function
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.