Submission Details
Severity:
Emission cap can never be updated
Summary
Updating emission cap functionality is not implemented in the gauge controller contract
Vulnerability Details
Following is set emission function
function setEmission(uint256 emission) external onlyController {
if (emission > periodState.emission) revert RewardCapExceeded();
periodState.emission = emission;
emit EmissionUpdated(emission);
}
It is only callable by the controller but in gauge controller contract there is not functionality for calling this function on the gauge thus emission for a period state cannot be updated.
Impact
Updation of emission paramter can never happen
Tools Used
Manual review
Recommendations
Implement this functionality in the gauge controller.
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
`setWeeklyEmission`, `setBoostParameters`, `setEmission` and `setInitialWeight` cannot be called due to controller access control - not implemented in controller
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
`setWeeklyEmission`, `setBoostParameters`, `setEmission` and `setInitialWeight` cannot be called due to controller access control - not implemented in controller
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.