Submission Details
Severity:
Incorrect DebtToken burn returned values order
Summary
In the LendingPool contract when repaying debt the amount burned and amount Scaled are returned in the incorrect order:
In the LendingPool::_repay function:
(uint256 amountScaled, uint256 newTotalSupply, uint256 amountBurned, uint256 balanceIncrease) =
IDebtToken(reserve.reserveDebtTokenAddress).burn(onBehalfOf, amount, reserve.usageIndex);
In the DebtToken::burn function:
return (amount, totalSupply(), amountScaled, balanceIncrease);
Basically in the LendingPools implementation the positions for amountScaled and amountBurned are swaped.
Impact
Incorrect values returned
Tools Used
Manual review
Recommendations
Fix order of returned values
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
DebtToken::burn returns items in the wrong order
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
DebtToken::burn returns items in the wrong order
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.