Core Contracts

Summary
The deposit function in the Treasury contract uses the ERC-20 transferFrom method to deposit tokens. While this is a standard method, it lacks safety checks for token transfer failures.

Vulnerability Details
The transferFrom function used in the deposit method will not automatically revert on unexpected failures. This could allow for a failed deposit without clear error feedback, leading to an inconsistent state.

Impact
Severity: Low/Med
If a token contract fails or behaves unexpectedly, deposits could fail silently, leading to an inconsistent contract state.

Tools Used

• Manual code review

Recommendations
Replace transferFrom with safeTransferFrom to ensure that all token transfers are checked for success and revert on failure, enhancing security.