Submission Details
Severity:
Incorrect Comparison in the `RToken::burn` Function
Vulnerability Details
In the RToken::burn function, the amount variable represents the amount of crvUSD that the user wants to withdraw, while userBalance refers to the balance of RToken that the user possesses. These two values are not comparable because the RToken amount and the crvUSD amount do not have a 1:1 ratio.
Impact
This leads to incorrect calculations.
Tools Used
Manual review.
Recommendations
Convert userBalance to a non-scaled amount by multiplying it by the index before making the comparison.
- if(amount > userBalance){
- amount = userBalance;
- }
+ if(amount > userBalance.rayMul(index)){
+ amount = userBalance.rayMul(index);
+ }
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Reason: Incorrect statement
Assigned finding tags:
Wrong balance check in RToken::burn
It's underlying vs underlying
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.