Core Contracts

Summary

The function updateUserBoost contains an unnecessary check for paused() even though the function is already gated by the whenNotPaused modifier. This results in redundant code execution, which is inefficient and can be removed without affecting security.

Vulnerability Details

The updateUserBoost function contains the following check:

However, this function is already protected by the whenNotPaused modifier:

Since whenNotPaused ensures the function cannot be executed when the contract is paused, the explicit if (paused()) revert EmergencyPaused(); check is redundant.

Code Reference

Impact

• Unnecessary gas cost: The redundant check increases gas usage for every call to updateUserBoost.

• Code clutter: Including unnecessary conditions makes the codebase less clean and harder to maintain.

Tools Used

• Manual code review

Recommendations

Remove the redundant if (paused()) revert EmergencyPaused(); check since whenNotPaused already ensures that the function cannot be executed when the contract is paused.

Suggested Fix