Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

Incorrect distribution share configuration for Swap Tax (`feeTypes[6]`) in `FeeCollector.sol`. Shares do not sum to 100%, leading to misallocation of fees.

mo_

Summary

Incorrect distribution share configuration for Swap Tax (feeTypes[6]) in FeeCollector.sol. Shares do not sum to 100%, leading to misallocation of fees.

Vulnerability Details

The feeTypes[6] configuration for Swap Tax fees defines distribution shares that sum to only 20% of the total collected fees, instead of the expected 100% (BASIS_POINTS). This means that 80% of the collected Swap Tax fees are unaccounted for in the current configuration and will not be distributed as intended.

Code Snippet:

​
// contracts/core/collectors/FeeCollector.sol
​
```Solidity
function _initializeFeeTypes() internal {
// ...
// Buy/Sell Swap Tax (2% total)
feeTypes[6] = FeeType({
veRAACShare: 500, // 0.5%
burnShare: 500, // 0.5%
repairShare: 1000, // 1.0%//@lead should be 10% , or 0.1% of 2% total as commented ! cause adding all the shares it doesnot concludes to 10000(100%) as it should be
treasuryShare: 0
});
// ...
}

The sum of veRAACShare, burnShare, repairShare, and treasuryShare for feeTypes[6] is 2000, not the expected BASIS_POINTS (10000).

Impact

  • Loss of Undistributed Fees: 80% of Swap Tax fees will not be allocated to any of the intended recipients (veRAAC holders, burn, repair fund, treasury).

  • Incorrect Fee Distribution: The intended distribution ratios for Swap Tax fees are not being correctly implemented.

Tools Used

Manual code review.

Recommendations

Correct the distribution shares for feeTypes[6] to ensure they sum up to BASIS_POINTS (10000). Review the intended distribution percentages for Swap Tax fees and update the veRAACShare, burnShare, repairShare, and treasuryShare values accordingly.

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!