Submission Details
Severity:
Missing Zero Price Check
Summary
not checking if _amount is greater than 0
Vulnerability Details
should check if _amount is greater than 0 in case something with the oracle went wrong
function setHousePrice(
uint256 _tokenId,
uint256 _amount
) external onlyOracle {
tokenToHousePrice[_tokenId] = _amount;
lastUpdateTimestamp = block.timestamp;
emit PriceUpdated(_tokenId, _amount);
}
Impact
if _amount is 0 something wrong might have happened to the oracle, checking it can prevent a 0 price.
Tools Used
manual
Recommendations
check if _amount > 0
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.