Core Contracts

Summary

Inconsistency between documented total allocation (65%) and implemented allocation (65.1%) in RAACReleaseOrchestrator.sol.

Vulnerability Details

The RAACReleaseOrchestrator.sol contract constructor initializes category allocations intended to represent 65% of the total token supply, as stated in documentation (RAACReleaseOrchestrator.md) and code comments. However, summing the individual category percentages in the constructor results in a total allocation of 65.1%, a slight discrepancy from the documented 65%.

Code Snippet:

Adding the percentages: 18% + 10.3% + 5% + 10% + 15% + 6.8% = 65.1%, not 65%.

Impact

• Documentation Inconsistency: Discrepancy between code implementation and documentation can cause confusion and miscommunication.

• Minor Deviation from Planned Distribution: Slightly more tokens are allocated in the initial distribution than documented (0.1% difference).

Tools Used

Manual code review and documentation review.

Recommendations

Verify the intended total allocation percentage for these categories.

1. Correct Code to Match Documentation (if 65% intended): Adjust one or more category allocations in the constructor to ensure the sum is exactly 65%. For example, reduce ADVISOR_CATEGORY to 10.2% (10,200,000 ether).

2. Update Documentation to Match Code (if 65.1% intended): Update RAACReleaseOrchestrator.md to reflect the 65.1% total allocation.