Submission Details
Severity:
LendingPool can use stale NFT price from the oracle
Summary
When LendingPool gets the current price of an NFT from the oracle it does not checks price for staleness.
Vulnerability Details
LendingPool::getNFTPrice calls priceOracle.getLatestPrice that returns price and lastUpdateTimestamp (link), but timestamp is unused.
Impact
Price oracle can return stale NFT price and LendingPool will allow to withdraw NFT and user will be under collateralized (link)
Tools Used
Manual code review
Recommendations
Check returned by oracle last price update timestamp for staleness
Updates
Lead Judging Commences
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
LendingPool::getNFTPrice or getPrimeRate doesn't validate timestamp staleness despite claiming to, allowing users to exploit outdated collateral values during price drops
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
LendingPool::getNFTPrice or getPrimeRate doesn't validate timestamp staleness despite claiming to, allowing users to exploit outdated collateral values during price drops
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.