Submission Details
Severity:
Incorrect revert message in the `LendingPool::initiateLiquidation` function.
Summary
The initiateLiquidation function has an incorrect revert message.
Vulnerability Details
The if condition checks whether the user's health factor is greater or less than healthFactorLiquidationThreshold. If it is greater, liquidation should not be initiated, and the function should revert.
But the revert message "HealthFactorTooLow" is incorrect; it should be something like "HealthFactorIsGood" to indicate that liquidation cannot proceed.
function initiateLiquidation(address userAddress) external nonReentrant whenNotPaused {
if (isUnderLiquidation[userAddress]) revert UserAlreadyUnderLiquidation();
// update state
ReserveLibrary.updateReserveState(reserve, rateData);
UserData storage user = userData[userAddress];
uint256 healthFactor = calculateHealthFactor(userAddress);
@>> if (healthFactor >= healthFactorLiquidationThreshold) revert HealthFactorTooLow();
isUnderLiquidation[userAddress] = true;
liquidationStartTime[userAddress] = block.timestamp;
emit LiquidationInitiated(msg.sender, userAddress);
}
Impact
Incorrect revert message.
Recommendations
-if (healthFactor >= healthFactorLiquidationThreshold) revert HealthFactorTooLow();
+if (healthFactor >= healthFactorLiquidationThreshold) revert HealthFactorIsGood();
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.