Submission Details
Severity:
RAACHousePrices oracle uses single timestamp for all tokens
Summary
Timestamps of house prices should be updated for each token individually, but RAACHousePrices uses the same lastUpdateTimestamp storage variable for all tokens.
Vulnerability Details
RAACHousePrices.lastUpdateTimestamp is updated on every RAACHousePrices::setHousePrice call (link), so when RAACHousePrices::getLatestPrice is called for some _tokenId it returns lastUpdateTimestamp updated by some another _tokenId (link).
Impact
House price oracle can return fresh timestamp for staled price
Tools Used
Manual code review
Recommendations
Store timestamps for each token individually
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
RAACHousePrices uses a single global lastUpdateTimestamp for all NFTs instead of per-token tracking, causing misleading price freshness data
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
RAACHousePrices uses a single global lastUpdateTimestamp for all NFTs instead of per-token tracking, causing misleading price freshness data
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.