Submission Details
Severity:
There is no stale price check for deposited nfts
Summary
There is no price staleness check for the depsoited nfts which can lead to liquidation too.
Vulnerability Details
Following is get price function
function getNFTPrice(uint256 tokenId) public view returns (uint256) {
(uint256 price, uint256 lastUpdateTimestamp) = priceOracle.getLatestPrice(tokenId);
if (price == 0) revert InvalidNFTPrice();
return price;
}
As can be seen that there is not check introduced which checks that the last update timestamp was within some recent time interval due to this price of nft may not be correct thus the collateral value will not be the correct one due this user can even get liquidated.
Impact
Wrong calculation of the total debt
Tools Used
Manual review
Recommendations
Check that the last update timestamp was within some time interval.
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
LendingPool::getNFTPrice or getPrimeRate doesn't validate timestamp staleness despite claiming to, allowing users to exploit outdated collateral values during price drops
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
LendingPool::getNFTPrice or getPrimeRate doesn't validate timestamp staleness despite claiming to, allowing users to exploit outdated collateral values during price drops
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.