Submission Details
Severity:
Stability pool has no logic to handle received NFTs
Vulnerability Details
Stability pool receives users' NFTs during the call to lendingPool.finalizeLiquidation. However, there's no logic to handle the received NFTs in the stability Pool. This can result in NFTs becoming permanently trapped in the Stability Pool contract.
finalizeLiquidation
for (uint256 i = 0; i < user.nftTokenIds.length; i++) {
uint256 tokenId = user.nftTokenIds[i];
user.depositedNFTs[tokenId] = false;
raacNFT.transferFrom(address(this), stabilityPool, tokenId);
}
The transfer was made using transferFrom which doesn't check for NFT receiver interface implementation.
Impact
Permanent loss of NFT assets which can lead to protocol insolvency
Tools Used
Manual
Recommendations
Implement logic to handle NFTs
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
Liquidated RAACNFTs are sent to the StabilityPool by LendingPool::finalizeLiquidation where they get stuck
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.