Submission Details
Severity:
calculateRcrvUSDAmount returns incorrect value
Summary
calculateRcrvUSDAmount returns incorrect value due to incorrect decimal conversion.
Vulnerability Details
Following is calculateRcrvUSDAmount function
function calculateRcrvUSDAmount(uint256 deCRVUSDAmount) public view returns (uint256) {
uint256 scalingFactor = 10**(18 + rTokenDecimals - deTokenDecimals);
return (deCRVUSDAmount * getExchangeRate()) / scalingFactor;
}
function getExchangeRate() public view returns (uint256) {
// uint256 totalDeCRVUSD = deToken.totalSupply();
// uint256 totalRcrvUSD = rToken.balanceOf(address(this));
// if (totalDeCRVUSD == 0 || totalRcrvUSD == 0) return 10**18;
// uint256 scalingFactor = 10**(18 + deTokenDecimals - rTokenDecimals);
// return (totalRcrvUSD * scalingFactor) / totalDeCRVUSD;
return 1e18;
}
So instead of multiplying the scaling factor and dividing the exchange rate the above function does the opposite due to which wrong conversion is done.
Impact
Wrong decimal conversion
Tools Used
Recommendations
Multiply the scaling factor and divide the getexchangerate
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Incorrect scaling factor formula in StabilityPool::calculateRcrvUSDAmount function
Both tokens have 18 decimals. Info
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.