Core Contracts

Summary

The constructor unnecessarily converts _usageIndex to uint128 despite its uint256 declaration. While WadRayMath.RAY (1e27) is compatible with uint128, this conversion adds complexity without benefits and could complicate future code modifications.

Vulnerability Details

• _usageIndex declaration as uint256 makes uint128 conversion redundant

• Type conversion provides no advantages given WadRayMath.RAY compatibility

• Potential gas inefficiencies and maintenance complications from unnecessary casting

Impact

• No direct security risk but introduces code inefficiency

• Future modifications may face compatibility issues due to type conversion

Tools Used

• Manual code review

Recommendations

• Initialize _usageIndex directly:

  _usageIndex = WadRayMath.RAY;

• Consider updating variable type to uint128 if specifically required