Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

L-1 Inadequate Time Check in whenActive Modifier May Cause Auction Delay by One Block Time

0x996

Description

In the whenActive modifier of the Auction contract, the condition block.timestamp > state.startTime is used to check if the auction has started. This implementation may result in the auction being considered as started one block after the expected start time, causing a delay in the auction.

Impact

  1. Due to the nature of Dutch auctions, a one-block delay in the auction start time will slightly lower the current ZENO price.

  2. In high-frequency trading or time-sensitive auctions, this delay may cause unnecessary competition and unfairness.

Recommendations

Modify the condition in the whenActive modifier from block.timestamp > state.startTime to block.timestamp >= state.startTime to ensure that the auction starts exactly at the state.startTime timestamp.

modifier whenActive() {
- require(block.timestamp > state.startTime, "Auction not started");
+ require(block.timestamp >= state.startTime, "Auction not started");
require(block.timestamp < state.endTime, "Auction ended");
_;
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!